Tweak the "excessive partial hash collisions" warnings #5752
+93
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solardiz
approved these changes
Apr 20, 2025
For salt-only formats, bump the warning threshold by x10. Closes openwall#5736
Blob formats can't use the fmt_default_(binary|get)_hash_[0..6] functions but need more elaborate functions, or plain fmt_default_binary_hash. Salt-only formats doesn't even have a binary, but are allowed to use fmt_default_(binary|get)_hash (without the trailing _0[..6]). See openwall#5736
magnumripper
force-pushed
the
fmt_blob-no-hash-collision-warning
branch
from
7a0fbc0 to
6bd9217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For salt-only formats, bump the warning threshold to
10xLDR_HASH_COLLISIONS_MAX.LDR_HASH_COLLISIONS_SALT_ONLYwhich is currently 10xLDR_HASH_COLLISIONS_MAXin params.h.Add a self-test for detecting misuse of default binary hash functions with FMT_BLOB formats.
Fix such bug in Office formats.
Closes #5736