Skip to content

more POD cleanup for Value/Matrices.pm #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

Alex-Jordan
Copy link
Contributor

This continues #1188, with POD changes (and minor code changes like foreach to for) that are largely the same as in #1076. For that reason I credited the commit to @pstaabp (hope that's OK). The diff between this branch and the #1076 branch should be a bit smaller than between #1076 and develop, only showing the new additions in #1076 plus some consequences of small things cleaned up here or in #1188.

To review this, you should just confirm that it is moving or lightly editing POD. And that any code changes are trivial/minor.

The next phase for this would be enhancing or changing existing methods, if we want to do any of that. For example enhancements like letting the row method take multiple arguments. And changes like treating 1D Matrix objects as column vectors instead of row vectors (regarding their presentation and interactions with 2D Matrix objects).

Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed over the changes, and overall looks good.

Should the links be updated to point to the new location for the wiki?

@Alex-Jordan
Copy link
Contributor Author

Should the links be updated to point to the new location for the wiki?

I'm not caught up on this. Where is the new location? There are local relative links here that just will go to a different POD page. And there are links here to the forums at webwork.maa.org/moodle/mod/forum. Which kind of thing do you mean?

@somiaj
Copy link
Contributor

somiaj commented Mar 2, 2025

It is the webwork.maa.org being moved to openwebwork.org. @dlglin knows the details on when this move will be completed, but the location of the wiki I think is now here https://wiki.openwebwork.org/wiki/WeBWorK_Main_Page

@drgrice1
Copy link
Member

drgrice1 commented Mar 2, 2025

Don't change the links at this point. The actual details of the move are not certain yet.

@dlglin
Copy link
Member

dlglin commented Mar 3, 2025

The new wiki location is not in production yet. It will live at the address you quoted, but right now that has an old copy of the wiki. Until we officially migrate please continue to make any wiki updates on the webwork.maa.org site.

The intention is to have webwork.maa.org point to the new server, so for the time being existing links shouldn't break. We'll set up redirects to try to get people to use the new URLs once they're ready to go.

@Alex-Jordan
Copy link
Contributor Author

Two approvals now, merge this? Phase 3 will be to review the existing methods and look for ways to improve them (either more efficient or more flexible).

@drgrice1 drgrice1 merged commit 36e2645 into openwebwork:develop Mar 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants