Protect static file routes from directory traversal attacks. #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using a URL like
http://baseURL/../../../../../../../../../../../../../../../../etc/passwd
returns the file/etc/passwd
. That of course is a security vulnerability that should not happen.This was recently discovered and fixed for webwork2, and basically the same solution is used to fix it here.
Below is a minimal script that can be used to test this:
Set
$server
to the URL of your renderer including the$baseURL
.With the develop branch the above script will output "success" followed by the contents of the
/etc/passwd
file on your server. With this branch it will output "error" followed by "Not found".