Fix double spares for failed vdev #17231
Open
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ixhamza
reviewed
Apr 9, 2025
amotin
reviewed
Apr 10, 2025
akashb-22
approved these changes
Apr 16, 2025
ixhamza
approved these changes
Apr 16, 2025
amotin
reviewed
Apr 18, 2025
There was a problem hiding this comment.
At the new place the function is called we already have the nvlist converted into actual vdevs. So while it might be a functional equivalent, I think it would be nice to be consistent with the code around and do the checks on the vdevs.
PS: Comments are good, but only while they fit the screen. ;)
tonyhutter
force-pushed
the
sparefix
branch
2 times, most recently
from
b31d080 to
3ca520e
Compare
When I was originally testing this, for whatever reason, Anyway, my latest push does away with the nvlist check and uses |
amotin
approved these changes
Apr 21, 2025
It's possible for two spares to get attached to a single failed vdev. This happens when you have a failed disk that is spared, and then you replace the failed disk with a new disk, but during the resilver the new disk fails, and ZED kicks in a spare for the failed new disk. This commit checks for that condition and disallows it. Closes: openzfs#16547 Signed-off-by: Tony Hutter <[email protected]>
amotin
approved these changes
Apr 24, 2025
ixhamza
approved these changes
Apr 25, 2025
behlendorf
approved these changes
Apr 25, 2025
behlendorf
added
Status: Accepted
behlendorf
reviewed
Apr 25, 2025
|
|
||
| /* | ||
| * To determine if this configuration would cause a double spare, we | ||
| * look at the vdev_op_type string of the parent vdev, and of the |
There was a problem hiding this comment.
nit:
Suggested change
| * look at the vdev_op_type string of the parent vdev, and of the | |
| * look at the vdev_ops struct type of the parent vdev, and of the |
behlendorf
reviewed
Apr 25, 2025
| * 4. New blank disk starts resilvering | ||
| * 5. While resilvering, new blank disk has IO errors and faults | ||
| * 6. 2nd spare is kicked in for new blank disk | ||
| * 7. At this point two spares are kicked in for the original disk1. |
There was a problem hiding this comment.
We should add this as a test case.
akashb-22
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes: #16547
Description
It's possible for two spares to get attached to a single failed vdev. This happens when you have a failed disk that is spared, and then you replace the failed disk with a new disk, but during the resilver the new disk fails, and ZED kicks in a spare for the failed new disk. This commit checks for that condition and disallows it.
Here's an example of what the double spares looks like:
How Has This Been Tested?
I was able to reproduce the issue in a VM for both traditional spares and draid spares, and confirmed this PR doesn't allow the 2nd spare to get attached.
Types of changes
Checklist:
Signed-off-by.