Skip to content

ZTS: Add bpftrace dependency to Linux VMs #17286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AttilaFueloep
Copy link
Contributor

Motivation and Context

Wrote a test which requires bpftrace.

Description

Add a bpftrace dependency to the Linux VMs.

How Has This Been Tested?

Verified that all Linux VMs install bpftrace by looking at the logfiles.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@AttilaFueloep
Copy link
Contributor Author

Rebased.

@robn
Copy link
Member

robn commented Apr 29, 2025

I think it needs to be in tests/zfs-tests/include/commands.cfg as well?

(Not gonna lie: my gut feel on needing bpftrace for a test feels sketchy, but I can't quite put my finger on it. I'll reserve judgement until I see the test though).

@tonyhutter
Copy link
Contributor

@AttilaFueloep these changes should be included in your future PR with the test case, rather than a standalone PR now. If you are just wanting to test the CI, you can open a private PR against your AtillaFueloep:zfs repo and it will startup your github runners.

@AttilaFueloep
Copy link
Contributor Author

@robn

I think it needs to be in tests/zfs-tests/include/commands.cfg as well?

Yeah, right. Thanks for noting.

@tonyhutter Ah all right, makes sense. Sorry for the noise. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants