internal/pkg/action/catalog_add.go: several improvements #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When pulling images and image labels for an index image that is a manifest list, try all platforms rather than just the platform on which the `kubectl operator` command is running. This fixes an issue with using the `catalog add` command on macOS with manifest list-based index images - When using bundle injection use the presence of the database path label to determine if the image is an empty base index rather than hardcoding the known empty base index images. Also use the value from the database path label instead of hardcoding the database path. - Change display name and publisher labels to an alpha subdomain: * alpha.operators.operatorframework.io.index.display-name.v1 * alpha.operators.operatorframework.io.index.publisher.v1 - Adding an owner reference to the index image registry pod no longer requires an extra Update call to the API server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling images and image labels for an index image that is a manifest list, try all platforms rather than just the platform on which the
kubectl operatorcommand is running. This fixes Failure when adding catalog on macOS #18, which is an issue with using thecatalog addcommand on macOS with manifest list-based index images.When using bundle injection use the presence of the database path label to determine if the image is an empty base index rather than hardcoding the known empty base index images. Also use the value from the database path label instead of hardcoding the database path.
Change display name and publisher labels to an alpha subdomain:
Adding an owner reference to the index image registry pod no longer requires an extra Update call to the API server