test: run stuff in parallel #787
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
xdist-again
branch
6 times, most recently
from
411671b to
5ecbf10
Compare
Use filelock.FileLock to workaround the issue that session fixtures do not work with xdist. This should probably be redone in some less hard to read way :(
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use filelock.FileLock to workaround the issue that session fixtures do not work with xdist. This should probably be redone in some less hard to read way :(
[edit: results so far not too encouraging, also for some reason the most important function to parallize is build_images() but that for some reason (pytest scopes side-effects?) is only run in sequence even though it it supposed to be parrallel with e.g. "sudo pytest -s -n 8 ./test/test_build.py::test_iso_installs"]
[edit2: I (strongly) suspect the issue is the indirect paramerization of the fixtures, it seems those cannot be parallelized by xdist so we need to rework/remove the fixtures which is probably a good idea anyway as they got a bit out of hand here]
Results:
(just for reference: on my machine with a moderate network connection /var/tmp/bib-tests takes 54G and a -n 16 run takes 38min, the runners have 66G on /mnt and require around 10G of /var/lib/containers storage)