feat: Add Uv Python package manager #10020

heliocastro · 2025-03-11T08:23:04Z

Uv is Astral.sh Python package/project manager solution. The backend is based on Rust and is a merge result of two projects, the original package manager uv and the Python project manager rye,

Reference:

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt

plugins/package-managers/python/src/main/kotlin/Uv.kt

helper-cli/src/main/kotlin/commands/repoconfig/GenerateScopeExcludesCommand.kt

plugins/package-managers/python/src/main/kotlin/Uv.kt

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt

codecov · 2025-03-11T17:25:33Z

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (d50c3ae) to head (f0c902f).

Files with missing lines	Patch %	Lines
...nagers/python/src/main/kotlin/utils/PythonUtils.kt	63.15%	1 Missing and 6 partials ⚠️
...ommands/repoconfig/GenerateScopeExcludesCommand.kt	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10020      +/-   ##
============================================
- Coverage     69.59%   69.55%   -0.04%     
  Complexity     1462     1462              
============================================
  Files           270      270              
  Lines          9665     9690      +25     
  Branches       1025     1034       +9     
============================================
+ Hits           6726     6740      +14     
- Misses         2489     2495       +6     
- Partials        450      455       +5

Flag	Coverage Δ
funTest-docker	`68.19% <63.15%> (+<0.01%)`	⬆️
funTest-non-docker	`33.26% <0.00%> (-0.04%)`	⬇️
test-ubuntu-24.04	`39.37% <48.00%> (+0.03%)`	⬆️
test-windows-2022	`39.35% <48.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

plugins/package-managers/python/src/test/kotlin/PythonUtilsTest.kt

Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>

plugins/package-managers/python/src/test/kotlin/utils/PythonUtilsTest.kt

Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>

sschuberth · 2025-03-14T08:27:34Z

Just as a somewhat related remark, Dependabot now can also handle uv.

heliocastro · 2025-03-14T14:47:56Z

Just as a somewhat related remark, Dependabot now can also handle uv.

Right on time, i say

sschuberth

I believe this needs major rework for work without python-inspector, which is know to have several problems.

Please also remove the merge commit from the history.

sschuberth · 2025-03-17T16:33:28Z

Dockerfile

@@ -147,6 +147,7 @@ ARG PYTHON_PIPENV_VERSION
 ARG PYTHON_POETRY_VERSION
 ARG PYTHON_POETRY_PLUGIN_EXPORT_VERSION
 ARG PYTHON_SETUPTOOLS_VERSION
+ARG PYTHON_UV_VERSION


As this is the first commit introducing uv, the commit should briefly explain what it is, plus contain a link to https://docs.astral.sh/uv/.

Spelling-wise, it seems we should use "uv" instead of "Uv".

Also, the commit message should make explicit that this is done as a preparation for adding uv support as a package manager in ORT.

sschuberth · 2025-03-17T16:34:14Z

docker/versions.dockerfile

@@ -25,6 +25,7 @@ ARG PYTHON_POETRY_VERSION=2.0.1
 ARG PYTHON_POETRY_PLUGIN_EXPORT_VERSION=1.9.0
 ARG PYTHON_SETUPTOOLS_VERSION=74.1.3
 ARG PYTHON_VERSION=3.11.10
+ARG PYTHON_UV_VERSION=0.6.5


By now, there's https://github.com/astral-sh/uv/releases/tag/0.6.6.

sschuberth · 2025-03-17T16:36:37Z

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt

+import org.ossreviewtoolkit.utils.test.matchExpectedResult
+
+class UvFunTest : WordSpec({
+    "Python 3" should {


"Python 3" -> "Uv"

sschuberth · 2025-03-17T16:39:16Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+internal object UvCommand : CommandLineTool {
+    override fun command(workingDir: File?) = "uv"
+
+    override fun transformVersion(output: String) = output.substringAfter("version ").removeSuffix(")")


For me, the version output is

$ uv --version uv 0.6.2

So why the .substringAfter("version ").removeSuffix(")")? Shouldn't it be just .substringAfter("uv ")?

sschuberth · 2025-03-17T16:43:23Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+ */
+@OrtPlugin(
+    displayName = "Uv",
+    description = "An extremely fast Python package and project manager.",


IMO we should not adopt to their marketing language here, and drop "extremely fast". So just say "A Python package and project manager".

sschuberth · 2025-03-17T16:46:52Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+    description = "An extremely fast Python package and project manager.",
+    factory = PackageManagerFactory::class
+)
+class Uv(override val descriptor: PluginDescriptor = UvFactory.descriptor, private val config: PipConfig) :


I believe the only reason why Pip.kt, Pipenv.kt and Poetry.kt shared PipConfig so far is that all of these are handled by python-inspector (and PipConfig contains python-inspector-specific config).

But for the independent Uv implementation, I believe we should have a separate UvConfig.

sschuberth · 2025-03-17T17:16:06Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+        internal const val PYPROJECT_FILENAME = "pyproject.toml"
+    }
+
+    override val globsForDefinitionFiles = listOf("uv.lock")


This line triggered cc7059a on my side. Once that PR is merged, please take over the final wording of that comment here.

sschuberth · 2025-03-17T17:29:38Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+            .distinctBy { it.id }
+            .toSet()


This also looks unnecessary. As I realize you've copied this from the Poetry implementation, I'm removing that as part of #10051 as well.

sschuberth · 2025-03-17T17:33:04Z

plugins/package-managers/python/src/main/kotlin/Uv.kt

+    }
+
+    /**
+     * Return the result of running Python inspector against a requirements file generated by exporting the dependencies


Oh, so you are using python-inspector after all... not that falling back to using requirements.txt files should really just be a last resort, as those files only contain a flat list of direct dependencies without much metadata.

I was under the assumption that a modern manager like uv offers better ways to query dependencies.

sschuberth · 2025-03-17T17:39:37Z

I believe this needs major rework for work without python-inspector, which is know to have several problems.

So I guess we'd want astral-sh/uv#4711 to be implemented.

heliocastro added the analyzer label Mar 11, 2025

heliocastro self-assigned this Mar 11, 2025

github-advanced-security bot found potential problems Mar 11, 2025

View reviewed changes

heliocastro force-pushed the feat/python_uv branch from eca7fa1 to 61dff26 Compare March 11, 2025 08:32

github-advanced-security bot found potential problems Mar 11, 2025

View reviewed changes

helper-cli/src/main/kotlin/commands/repoconfig/GenerateScopeExcludesCommand.kt Fixed Show fixed Hide fixed

heliocastro force-pushed the feat/python_uv branch from 61dff26 to f9c0758 Compare March 11, 2025 08:53

github-advanced-security bot found potential problems Mar 11, 2025

View reviewed changes

plugins/package-managers/python/src/main/kotlin/Uv.kt Fixed Show fixed Hide fixed

heliocastro force-pushed the feat/python_uv branch 2 times, most recently from 27a370a to 8e01f73 Compare March 11, 2025 16:47

github-advanced-security bot found potential problems Mar 11, 2025

View reviewed changes

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt Fixed Show fixed Hide fixed

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt Fixed Show fixed Hide fixed

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 11, 2025

View reviewed changes

plugins/package-managers/python/src/funTest/kotlin/UvFunTest.kt Fixed Show fixed Hide fixed

heliocastro force-pushed the feat/python_uv branch from 45a10e7 to 2638532 Compare March 11, 2025 17:44

heliocastro marked this pull request as ready for review March 11, 2025 18:08

heliocastro requested review from a team as code owners March 11, 2025 18:08

heliocastro force-pushed the feat/python_uv branch 3 times, most recently from 1b134d5 to ed7dd63 Compare March 12, 2025 07:51

github-advanced-security bot found potential problems Mar 12, 2025

View reviewed changes

plugins/package-managers/python/src/test/kotlin/PythonUtilsTest.kt Fixed Show fixed Hide fixed

heliocastro force-pushed the feat/python_uv branch 2 times, most recently from 11ffddc to 736c767 Compare March 12, 2025 11:19

feat: Add Uv tooling to Ort Docker image

fd5fb3a

Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>

heliocastro force-pushed the feat/python_uv branch from 736c767 to 3789735 Compare March 12, 2025 11:25

github-advanced-security bot found potential problems Mar 12, 2025

View reviewed changes

plugins/package-managers/python/src/test/kotlin/utils/PythonUtilsTest.kt Fixed Show fixed Hide fixed

feat: Add Uv Python package manager

5a34f28

Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>

heliocastro force-pushed the feat/python_uv branch from 3789735 to 5a34f28 Compare March 12, 2025 11:39

Merge branch 'main' into feat/python_uv

f0c902f

sschuberth requested changes Mar 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Uv Python package manager #10020

feat: Add Uv Python package manager #10020

heliocastro commented Mar 11, 2025 •

edited

Loading

codecov bot commented Mar 11, 2025 •

edited

Loading

sschuberth commented Mar 14, 2025

heliocastro commented Mar 14, 2025

sschuberth left a comment

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth Mar 17, 2025

sschuberth commented Mar 17, 2025

feat: Add Uv Python package manager #10020

Are you sure you want to change the base?

feat: Add Uv Python package manager #10020

Conversation

heliocastro commented Mar 11, 2025 • edited Loading

codecov bot commented Mar 11, 2025 • edited Loading

Codecov Report

sschuberth commented Mar 14, 2025

heliocastro commented Mar 14, 2025

sschuberth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sschuberth commented Mar 17, 2025

heliocastro commented Mar 11, 2025 •

edited

Loading

codecov bot commented Mar 11, 2025 •

edited

Loading