-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use environments to install Conan #10127
base: main
Are you sure you want to change the base?
Conversation
RUN eval "$(pyenv init - bash)" \ | ||
&& eval "$(pyenv virtualenv-init -)" \ | ||
&& pyenv virtualenv conan \ | ||
&& pyenv activate conan \ | ||
&& pip install conan==${CONAN_VERSION} \ | ||
&& pyenv deactivate \ | ||
&& pyenv virtualenv conan2 \ | ||
&& pyenv activate conan2 \ | ||
&& pip install conan==${CONAN2_VERSION} \ | ||
&& pyenv deactivate \ | ||
&& sudo chmod +x ${PYENV_ROOT}/bin/conan |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
Click Remediation section below to solve this issue
RUN eval "$(pyenv init - bash)" \ | ||
&& eval "$(pyenv virtualenv-init -)" \ | ||
&& pyenv virtualenv conan \ | ||
&& pyenv activate conan \ | ||
&& pip install conan==${CONAN_VERSION} \ | ||
&& pyenv deactivate \ | ||
&& pyenv virtualenv conan2 \ | ||
&& pyenv activate conan2 \ | ||
&& pip install conan==${CONAN2_VERSION} \ | ||
&& pyenv deactivate \ | ||
&& sudo chmod +x ${PYENV_ROOT}/bin/conan |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
Click Remediation section below to solve this issue
aa2e6e1
to
17e8541
Compare
17e8541
to
6953358
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10127 +/- ##
=========================================
Coverage 69.59% 69.59%
Complexity 1454 1454
=========================================
Files 270 270
Lines 9670 9670
Branches 1029 1029
=========================================
Hits 6730 6730
Misses 2488 2488
Partials 452 452
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9a52c9c
to
7ecc19b
Compare
c4ad09c
to
5976150
Compare
@heliocastro I did the changes. Could you please have a look ? Among other, I removed the echos in the script, as it broke the integration (ORT parses the output of the Conan command). @sschuberth Is it normal the commits are marked as "unverified" ? There are both Helio's and my signature in the commit messages. |
5976150
to
d98bb1e
Compare
- Move previous conan/conan2 naming approach to Python environment solution. A wrapper that detects CONAN_SERIES environment var switchis between the two release series. Defaults to CONAN_SERIES=2. - Enable profile creation support by default Passing environment var CONAN_CREATE_PROFILE=false will prevent to generate a default profile. Signed-off-by: Helio Chissini de Castro <[email protected]> Signed-off-by: Nicolas Nobelis <[email protected]>
…nments Signed-off-by: Nicolas Nobelis <[email protected]>
…efault This new profile is created with `-detect` therefore it will contains the compilation flags. This is cleaner as it allows to remove the passing of the compilation flags from the package manager. It also fix the usage of Conan on non-Linux plaforms. Signed-off-by: Nicolas Nobelis <[email protected]>
- Remove DUMMY_COMPILER_SETTINGS from plugin code as breaks any non-linux systems. Signed-off-by: Helio Chissini de Castro <[email protected]> Signed-off-by: Nicolas Nobelis <[email protected]>
d98bb1e
to
d95e56a
Compare
Yes, it's normal, as "unverified" refers to cryptographically signing commits, not the |
Move previous conan/conan2 naming approach to Python environment solution. A wrapper that detects CONAN_SERIES environment var switchis between the two release series. Defaults to CONAN_SERIES=2.
Enable profile creation support by default Passing environment var CONAN_CREATE_PROFILE=false will prevent to generate a default profile.
This is somehow how it works: