fix(yarn): Properly close the disk cache after resolution #10159
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10159 +/- ##
============================================
- Coverage 69.59% 69.52% -0.08%
+ Complexity 1454 1453 -1
============================================
Files 270 270
Lines 9670 9672 +2
Branches 1029 1031 +2
============================================
- Hits 6730 6724 -6
- Misses 2488 2494 +6
- Partials 452 454 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Let before / after resultion callbacks more closely "embrace" resolution. Signed-off-by: Sebastian Schuberth <[email protected]>
This is a fixup for 852e377. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
yarn-close-diskcache
branch
from
a2e69d8 to
4dfeb72
Compare
Also open the disk cache lazily at runtime instead of the start of the application. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
yarn-close-diskcache
branch
from
4dfeb72 to
a308e4d
Compare
auto-merge was automatically disabled
April 11, 2025 13:34
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also open the disk cache lazily at runtime instead of the start of the application.