Various common utility refactorings #10181
Open
+713
−620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
requested changes
Apr 16, 2025
plugins/reporters/static-html/src/main/kotlin/StaticHtmlReporter.kt
Outdated
Show resolved
Hide resolved
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
from
613844a to
39d768c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
auto-merge was automatically disabled
April 16, 2025 13:32
Pull request was converted to draft
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
2 times, most recently
from
3a16290 to
29df942
Compare
fviernau
approved these changes
Apr 17, 2025
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
from
29df942 to
381047e
Compare
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
2 times, most recently
from
7834193 to
eb687ee
Compare
fviernau
previously approved these changes
Apr 17, 2025
Make it `private` now as well and strip docs for this simple function. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Testing with `lowercase()` and `uppercase()` is enough. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Create various smaller files with more dedicated names for a better overview. Apply some trivial alignments as part of that, like renaming of variables or generalizing `Collection` to `Iterable`. Signed-off-by: Sebastian Schuberth <[email protected]>
This allows for slightly more convenient use. Signed-off-by: Sebastian Schuberth <[email protected]>
A `realFile` already is absolute. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
from
eb687ee to
639b8c5
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
This makes `common-utils` Jackson-free, which is a step towards being able to make it a multi-platform project. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
realfile-vs-canonicalfile
branch
from
639b8c5 to
5fac8d9
Compare
|
I had to drop the
commit, because actually |
| @@ -746,7 +746,8 @@ private fun joinNonBlank(vararg strings: String, separator: String = " - ") = | |||
| strings.filter { it.isNotBlank() }.joinToString(separator) | |||
|
|
|||
| private fun IssueTable.title(): String = | |||
| "${type.name.titlecase()} Issue Summary ($errorCount errors, $warningCount warnings, $hintCount hints to resolve)" | |||
| type.name.lowercase().uppercaseFirstChar() + | |||
There was a problem hiding this comment.
FYI, the ORT workbench is using the removed function in several places.
| * License-Filename: LICENSE | ||
| */ | ||
|
|
||
| package org.ossreviewtoolkit.utils.common |
There was a problem hiding this comment.
Why not keep these in a Utils.kt? We use that name in several modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.