Skip to content

Yarn chores #9833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Yarn chores #9833

merged 6 commits into from
Jan 24, 2025

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth requested a review from a team as a code owner January 24, 2025 17:32
@sschuberth sschuberth enabled auto-merge (rebase) January 24, 2025 17:32
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (3eb2b4a) to head (a16d9be).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...e-managers/node/src/main/kotlin/yarn/ModuleInfo.kt 66.66% 0 Missing and 1 partial ⚠️
...node/src/main/kotlin/yarn/YarnDependencyHandler.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9833      +/-   ##
============================================
+ Coverage     68.11%   68.12%   +0.01%     
- Complexity     1287     1293       +6     
============================================
  Files           249      250       +1     
  Lines          8837     8843       +6     
  Branches        918      918              
============================================
+ Hits           6019     6024       +5     
  Misses         2432     2432              
- Partials        386      387       +1     
Flag Coverage Δ
funTest-docker 65.14% <87.50%> (-0.02%) ⬇️
funTest-non-docker 33.35% <ø> (ø)
test-ubuntu-24.04 35.77% <31.25%> (-0.02%) ⬇️
test-windows-2022 35.74% <31.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau
Copy link
Member

Are you aware of #9427?

@sschuberth
Copy link
Member Author

sschuberth commented Jan 24, 2025

Are you aware of #9427?

Yes. These are just small annoyances I came across while debugging issues with #9780.

@sschuberth sschuberth merged commit 90ec14e into main Jan 24, 2025
26 checks passed
@sschuberth sschuberth deleted the yarn-chores branch January 24, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants