Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3Client static methods are not marked as such #18818

Open
thexeos opened this issue Apr 7, 2025 · 0 comments · May be fixed by #18819
Open

S3Client static methods are not marked as such #18818

thexeos opened this issue Apr 7, 2025 · 0 comments · May be fixed by #18819
Labels
bug Something isn't working types An issue with TypeScript types

Comments

@thexeos
Copy link
Contributor

thexeos commented Apr 7, 2025

What version of Bun is running?

No response

What platform is your computer?

No response

What steps can reproduce the bug?

Static methods presign, exists, stat, delete, as well as several undocumented methods are not marked as static.

https://bun.sh/docs/api/s3#s3client-static-methods

bun/src/bun.js/api/S3Client.classes.ts

Lines 9 to 47 in e75d226

klass: {
file: {
fn: "staticFile",
length: 2,
},
unlink: {
fn: "staticUnlink",
length: 2,
},
delete: {
/// just an alias for unlink
fn: "staticUnlink",
length: 2,
},
list: {
fn: "staticListObjects",
length: 2,
},
presign: {
fn: "staticPresign",
length: 2,
},
exists: {
fn: "staticExists",
length: 2,
},
size: {
fn: "staticSize",
length: 2,
},
write: {
fn: "staticWrite",
length: 2,
},
stat: {
fn: "staticStat",
length: 2,
},
},

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response
@thexeos thexeos added bug Something isn't working types An issue with TypeScript types labels Apr 7, 2025
thexeos added a commit to thexeos/bun that referenced this issue Apr 7, 2025
@thexeos
bun-types: add static modifiers to static S3Client methods (oven-sh#1…
20be0e4 
…8818)
@thexeos thexeos linked a pull request Apr 7, 2025 that will close this issue
Open
1 task
thexeos added a commit to thexeos/bun that referenced this issue Apr 7, 2025
@thexeos
bun-types: add static modifiers to static S3Client methods (oven-sh#1…
7f08ce7 
…8818)
@thexeos thexeos mentioned this issue Apr 7, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working types An issue with TypeScript types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bun-types: add static modifiers to static S3Client methods (#18818) thexeos/bun
1 participant
@thexeos