bun-types: add static modifiers to static S3Client methods (#18818) #18819
+349
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR - I actually didn't know we supported these until now😅 Looks like we have some other supported static methods. Would be great if you could add these also, as it's within scope of this PR
Once that's added I'll give this an approval and we can get it merged. Thanks again |
|
I keep forgetting that TS is elegant. The missing JSDocs are now back. |
1 task
alii
reviewed
Apr 7, 2025
alii
reviewed
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds missing static method declarations for
S3Client. Preference is given to instance methods, so JSDoc will only show for those and not for static ones.Closes #18818