more child-process #18688

pfgithub · 2025-03-31T23:09:26Z

What does this PR do?

test-child-process-reject-null-bytes (prefer #15163?) (Fixes BUN-13252)

failure in bun-debug test ./test/js/bun/net/tcp.test.ts, reproduces locally
- this is failing on main

test-child-process-emfile (Fixes BUN-13253)

robobun · 2025-03-31T23:09:34Z

^{Updated 9:51 PM PT - Apr 11th, 2025}

❌ @pfgithub, your commit a648eaf has 5 failures in Build #14854:

test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 22.04 x64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-cluster-send-deadlock.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🍎 13 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🍎 14 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 3.21 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 3.21 x64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 22.04 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 20.04 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 12 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 24.04 aarch64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 22.04 x64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 12 x64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 24.04 x64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 20.04 x64
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 12 x64-baseline
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-net-server.js - timeout on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 22.04 x64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-child-process-fork-closed-channel-segfault.js - code 1 on 🐧 12 x64-baseline
scripts/build.mjs - build failed on 🪟 x64 - build-cpp
scripts/build.mjs - build failed on 🪟 x64 - build-cpp
scripts/build.mjs - build failed on 🪟 x64-baseline - build-cpp
scripts/build.mjs - build failed on 🪟 x64-baseline - build-cpp
src/bun.js/api/bun/subprocess.zig - zig error on 🪟 x64-baseline - build-zig
src/bun.js/ipc.zig - zig error on 🪟 x64-baseline - build-zig
src/bun.js/javascript.zig - zig error on 🪟 x64-baseline - build-zig
src/bun.js/node/node_cluster_binding.zig - zig error on 🪟 x64-baseline - build-zig
src/bun.js/node/node_cluster_binding.zig - zig error on 🪟 x64-baseline - build-zig
src/bun.js/api/bun/subprocess.zig - zig error on 🪟 x64 - build-zig
src/bun.js/ipc.zig - zig error on 🪟 x64 - build-zig
src/bun.js/javascript.zig - zig error on 🪟 x64 - build-zig
src/bun.js/node/node_cluster_binding.zig - zig error on 🪟 x64 - build-zig
src/bun.js/node/node_cluster_binding.zig - zig error on 🪟 x64 - build-zig

🧪 try this PR locally:

bunx bun-pr 18688

Jarred-Sumner · 2025-04-04T00:07:17Z

packages/bun-usockets/src/loop.c

@@ -391,7 +391,27 @@ void us_internal_dispatch_ready_poll(struct us_poll_t *p, int error, int eof, in
                      const int recv_flags = MSG_DONTWAIT | MSG_NOSIGNAL;
                    #endif

-                    int length = bsd_recv(us_poll_fd(&s->p), loop->data.recv_buf + LIBUS_RECV_BUFFER_PADDING, LIBUS_RECV_BUFFER_LENGTH, recv_flags);
+                    int length;
+                    if(s->context->is_ipc) {


can you put this on the socket type instead so we avoid this branch?

the branch is just before a syscall, is it important to avoid it?

the names are not defined in the spec & change connectionclosed to be AbortError

… time

test-child-process-reject-null-bytes

be1fdbe

pfgithub added 10 commits March 31, 2025 18:22

test-child-process-emfile

f1dc926

match node logic more closely

d828f25

support both emfile and enfile

887ee53

test-child-process-spawnsync-kill-signal

2d0829b

test-child-process-spawnsync-shell.js

57376f2

test-child-process-windows-hide

58dbcb0

test-child-process-detached

4da8ce1

test-child-process-prototype-tampering

511182f

abort signal stuff?

70cb404

use recvmsg() on ipc sockets

1fc70f4

Jarred-Sumner reviewed Apr 4, 2025

View reviewed changes

pfgithub added 17 commits April 3, 2025 17:32

on_fd

1932f61

unify doSend & fix the error is supposed to be on nextTick

185d417

write fd fn

85045a6

Merge branch 'main' into pfg/child-process

a1356ec

unify serializeAndSend{,Internal}

0a03f64

WIPPIW

8ec6bca

PIWIPIWIP

f64058a

no anytype

1adf00f

WIPPWI

25cad68

add ipc deinit and use it

b23c79c

maybe prepared for sending an ack now?

5152f3a

fix musl build

922ede7

note

7ea23d0

handle empty to_send case

9b49af4

WIPWPIWIPW

7769fda

WIWIPPIWWWIPWWIPPI

d747f41

<wip|piw|wip|piw>

b1fa295

pfgithub added 30 commits April 9, 2025 20:14

begin ipc.ts

de77f13

wip

09e9082

fixes 1

2c34f0c

fixes 2

4c10033

get test-child-process-fork passing again

1b6cb70

pass node-http2.ts again

8823893

pass serve.test.ts again

d3d57a9

the names are not defined in the spec & change connectionclosed to be AbortError

improve bundle-functions error display

d86f8ec

call js from zig now?

22f6f2e

remove std log info

4a29147

ban std.log.info

87d6cfe

(ban-words) std.debug.print -> limit 0

8f3e837

(ban-words) std.mem.indexOfAny(u8 -> limit 0

04b3127

notes

1ca57ae

Merge branch 'main' into pfg/child-process

997143e

fix after merge

0f047ee

pass test-child-process-send-after-close again

51f3496

simplify? logic

4c486a1

fix where makeAbortError is called so it doesn't call it at the wrong…

9397a41

… time

fix child_process_ipc.test.js

1b74733

wip

fb3fabb

use single quote rather than double quote

bfd648e

WIPWIPWIP

7219238

remove unneeded headers

c3c601d

fix creating the ipc socket for the child

2bdaccb

it sends a server. doesn't work yet though

27a1d0d

send the right message

0df9b24

notes

bbb67f1

eintr

285e701

it was listening with port = fd rather than trying to listen on the fd.

a648eaf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

more child-process #18688

more child-process #18688

pfgithub commented Mar 31, 2025 •

edited

Loading

robobun commented Mar 31, 2025 •

edited

Loading

Jarred-Sumner Apr 4, 2025

pfgithub Apr 4, 2025

more child-process #18688

Are you sure you want to change the base?

more child-process #18688

Conversation

pfgithub commented Mar 31, 2025 • edited Loading

What does this PR do?

robobun commented Mar 31, 2025 • edited Loading

Jarred-Sumner Apr 4, 2025

Choose a reason for hiding this comment

pfgithub Apr 4, 2025

Choose a reason for hiding this comment

pfgithub commented Mar 31, 2025 •

edited

Loading

robobun commented Mar 31, 2025 •

edited

Loading