Implement headersDistinct and fix NodeHTTPResponse.getAbort
#18709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1477,6 +1477,27 @@ const IncomingMessagePrototype = { | |||
| emitErrorNextTickIfErrorListenerNT(this, err, cb); | |||
| } | |||
| }, | |||
| get headersDistinct() { | |||
| if (this[Symbol.for("headersDistinctCache")]) { | |||
There was a problem hiding this comment.
Why is this a symbol.for?
| @@ -2286,6 +2286,34 @@ it("should not emit/throw error when writing after socket.end", async () => { | |||
| } | |||
| }); | |||
|
|
|||
| it("should correctly transform rawHeaders into headersDistinct", async () => { | |||
There was a problem hiding this comment.
did you try running this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
headersDistinctFixes null pointer dereference with
NodeHTTPResponse.getAbort, usethis: truein classes generation file to get the correct this value