Implement bun unlink {packageName}
#18713
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Saw that
bun unlink {packageName}
was unimplemented and gave it a shot. Fixes #7852.How did you verify your code works?
bun-debug test test-file-name.test
)It seemed like
manager.updatePackageJSONAndInstallWithManager()
ininstall.zig
mostly handles the case of unlinking. I accounted for three cases when writing this code:--save
is unlinked with--save
The current summary is not that helpful, but I haven’t yet wrapped my head around how the lockfile diffing works. The tricky thing with unlink is that it typically won’t create package.json changes, so I’m unsure how to show the unlinked packages as removed.