Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSC.Strong from NodeHTTPResponse #18728

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Remove the JSC.Strong for the Promise from NodeHTTPResponse. This means that the only strong reference to the NodeHTTPResponse object comes from the socket.

Note that this won't impact promise rejections because those are kept as strong inside the JSGlobalObject.

How did you verify your code works?

CI

@robobun
Copy link

robobun commented Apr 2, 2025

Updated 5:30 PM PT - Apr 2nd, 2025

@Jarred-Sumner, your commit 83cf798 has 1 failures in Build #14403:


🧪   try this PR locally:

bunx bun-pr 18728

@Jarred-Sumner Jarred-Sumner requested a review from heimskr April 3, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants