remove some usingnamespaces #18765
Merged
remove some usingnamespaces #18765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 2:08 PM PT - Apr 10th, 2025
✅ @paperclover, your commit 95cb524a34c58cdb7d1ba814fdf356b1d334ed2f passed in 🧪 try this PR locally: bunx bun-pr 18765 |
dylan-conway
reviewed
Apr 9, 2025
| } | ||
|
|
||
| fn free(ctx: *anyopaque, buf: []u8, alignment: std.mem.Alignment, ret_addr: usize) void { | ||
| const scope: *AllocationScope = @ptrCast(@alignCast(ctx)); | ||
| scope.state.mutex.lock(); | ||
| defer scope.state.mutex.unlock(); | ||
| var invalid = false; | ||
| const invalid = scope.trackFreeAssumeLocked(buf, ret_addr); |
There was a problem hiding this comment.
would this return true for 0?
const buf = alloc(u8, 0);
defer free(buf);
There was a problem hiding this comment.
std.mem.Allocator special cases zero length allocations and frees to do nothing
dylan-conway
reviewed
Apr 9, 2025
| @@ -979,7 +979,10 @@ pub fn CAresLookup(comptime cares_type: type, comptime type_name: []const u8) ty | |||
| next: ?*@This() = null, | |||
| name: []const u8, | |||
|
|
|||
| pub usingnamespace bun.New(@This()); | |||
| pub fn new(data: @This()) *@This() { | |||
| bun.assert(data.allocated); // deinit will not free this otherwise | |||
There was a problem hiding this comment.
We should remove .allocated in the future. It exists because we have allocations going through globalThis.allocator and bun.default_allocator.destroy in ResolveInfoRequest.init and onCaresComplete
dylan-conway
reviewed
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of previous PR #18353