Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP node:worker_threads fixes #18768

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

WIP node:worker_threads fixes #18768

wants to merge 35 commits into from
+877 −153

Conversation

190n
Copy link
Collaborator

@190n 190n commented Apr 4, 2025 •
edited
Loading

What does this PR do?

These are the changes from #18758 that caused regressions or needed deeper investigation to verify correctness:

  • Makes the online event fire right before a Worker starts running its entrypoint instead of right after (this is required behavior according to Node tests, but the way I've done it currently is breaking a lot of other Worker tests)
  • Makes MessagePort.close accept a callback (currently we just pass the callback to nextTick, instead of calling it exactly when the port is really closed)
  • Validates the first argument of the Worker constructor with the right error message
  • Fixes the error message when passing the wrong type to receiveMessageOnPort
  • Fixes the getEnvironmentData/setEnvironmentData implementation

How did you verify your code works?

Will add newly-passing Node tests and verify existing ones

@robobun
Copy link

robobun commented Apr 4, 2025 •
edited
Loading

Updated 7:28 PM PT - Apr 11th, 2025

❌ @190n, your commit ecc3622 has 11 failures in Build #14842:

🧪   try this PR locally:

bunx bun-pr 18768

@190n 190n mentioned this pull request Apr 4, 2025
Merged
4 tasks
190n and others added 26 commits April 7, 2025 16:58
@190n
Merge branch 'main' into ben/worker-threads-2
2b3ae71
@190n
Pass test-worker-type-check.js
bc420e4
@190n
Use more appropriate #include for errors
354f2cc
@190n
Correct receiveMessageOnPort error message
638c4b4
@190n
Add passing test
9ba5b89
@190n
Use defaultGlobalObject
dd7e5d4
@190n
Merge branch 'main' into ben/worker-threads-2
580ca99
@190n
Fire worker event on process
b74476c
@190n
Support worker environment data
cf5ad47
@190n
Add test-worker-abort-on-uncaught-exception-terminate.js
513c326
@190n
Refine error message for duplicates in transferList
38b20fb
@190n @github-actions
bun run clang-format
288dcd0
@190n
Do not unref worker on main thread when terminated
bd5f3aa
@190n
Terminate the VM in Worker.requestTerminate()
b7c7627
@190n
Add missing files
2d59005
@190n
Handle termination exception in next tick queue
8c6aa4e
@190n
Use exit code 1 if Worker entry point fails to load
2705a7b
@190n
Allow termination exception while fetching builtin
e857f54
@190n
Clean up exception handling in BunProcess.cpp
7b40950
@190n
Add more exception checks to JSNextTickQueue
604ae71
@190n
Merge branch 'main' into ben/worker-threads-2
37fae6b
@190n
Fix crash on workerData with no options
ed5966c
@190n
Fix null environment data
5d8217f
@190n
Do not propagate termination exception to event loop
5aeb80d
@190n
Un-todo "worker terminating forcefully properly interrupts" and fix e…
91a58f4 
…xpected exit code
@190n
Resolve Worker entrypoint on worker thread instead of main
097d298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@190n @robobun