Fix performance regression in node:http from #18599 #18798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
requested changes
Apr 5, 2025
| // This is the equivalent of checkIsHttpToken from internal/validators.js | ||
| // The regex is /^[\^_`a-zA-Z\-0-9!#$%&'*+.|~]+$/ | ||
| for (const auto& c : name) { | ||
| if (!(c == '^' || c == '_' || c == '`' || (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || c == '-' || (c >= '0' && c <= '9') || c == '!' || c == '#' || c == '$' || c == '%' || c == '&' || c == '\'' || c == '*' || c == '+' || c == '.' || c == '|' || c == '~')) { |
There was a problem hiding this comment.
is this faster than a switch statement? because is not easy to read
| @@ -41,6 +41,16 @@ bool isTokenCharacter(UChar c) | |||
| || c == '`' || c == '|' || c == '~'; | |||
| } | |||
|
|
|||
| bool isTokenCharacter(LChar c) | |||
| { | |||
| return isASCIIAlpha(c) || isASCIIDigit(c) | |||
There was a problem hiding this comment.
I just like how this is formatted in a way that is easier to read than a switch/case
| if (hasBody) { | ||
| // Don't automatically read the body, the user will need to resume() or .on("data") to read it. | ||
| // But, avoid the system call overhead unless we are going to receive body data. | ||
| handle.pause(); |
There was a problem hiding this comment.
I should have added this check from the start, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix performance regression in node:http from #18599
How did you verify your code works?