-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node:http) resume when reading and avoid unnecessary pause/resumes calls #18804
Conversation
Updated 4:08 PM PT - Apr 7th, 2025
❌ @cirospaciari, your commit 1270f4b has 1 failures in
🧪 try this PR locally: bunx bun-pr 18804 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether or not it's paused probably needs to go on the NodeHTTPSocket instead of the NodeHTTPResponse, right? Since the socket can outlive the response and we don't want to end up in a state where the previous response was paused and then the next request never happens
The socket will always be resumed if outlived, is_paused is needed here because it direct uses usockets with do not track this state raw_response is a opaque struct, we can change this flag to be inside usockets with makes more sense |
eb75a2f
to
5cc1a1f
Compare
c56efa1
to
bc59f6f
Compare
What does this PR do?
Fix: #18799
How did you verify your code works?
Tests