Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #18002 #18832

Merged
merged 3 commits into from
Apr 7, 2025
Merged

fix #18002 #18832

merged 3 commits into from
Apr 7, 2025

Conversation

dylan-conway
Copy link
Member

What does this PR do?

AsyncContextFrame does not pass an isCallable() check, making napi_call_function return napi_invalid_arg. I'm not sure this is the best way to do this. Ideally JSC should see AsyncContextFrame as callable so nothing needs to change here.

Fixes #18002

How did you verify your code works?

@robobun
Copy link

robobun commented Apr 7, 2025

Updated 1:06 PM PT - Apr 7th, 2025

@dylan-conway, your commit 0aa93d0 has 2 failures in Build #14567:


🧪   try this PR locally:

bunx bun-pr 18832

@dylan-conway dylan-conway requested a review from paperclover April 7, 2025 19:07
@Jarred-Sumner Jarred-Sumner merged commit 9fa3bc4 into main Apr 7, 2025
61 of 64 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/async-context-frame-not-callable branch April 7, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3.16 Compatibility
4 participants