Skip to content

[php-di v7] Loosen APCu check for SourceCache #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mod7
Choose a base branch
from
Open

[php-di v7] Loosen APCu check for SourceCache #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27cd8b2
feat: php-cs-fixer - removing deprecations
partikus Jan 10, 2024
28d15cb
Merge pull request #874 from ovos/feature/php-cs-fixer-deprecations
mnapoli Jan 10, 2024
25acbd2
Use sourceCache if isSupported check passes, otherwise proceed withou…
falkenhawk Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .php-cs-fixer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,14 @@
'@Symfony' => true,
'@Symfony:risky' => true,
'array_syntax' => ['syntax' => 'short'],
'braces' => [
'allow_single_line_closure' => true,
],
'single_space_around_construct' => true,
'control_structure_braces' => true,
'control_structure_continuation_position' => true,
'declare_parentheses' => true,
'no_multiple_statements_per_line' => true,
'braces_position' => true,
'statement_indentation' => true,
'no_extra_blank_lines' => true,
'concat_space' => [
'spacing' => 'one',
],
Expand Down
6 changes: 2 additions & 4 deletions src/ContainerBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,8 @@ public function build()
// Mutable definition source
$source->setMutableDefinitionSource(new DefinitionArray([], $autowiring));

if ($this->sourceCache) {
if (!SourceCache::isSupported()) {
throw new \Exception('APCu is not enabled, PHP-DI cannot use it as a cache');
}
// use cache if isSupported check passes, otherwise proceed without cache and do not throw an exception
if ($this->sourceCache && SourceCache::isSupported()) {
// Wrap the source with the cache decorator
$source = new SourceCache($source, $this->sourceCacheNamespace);
}
Expand Down