Skip to content

[release/12.4.1] Release 12.4.1 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[release/12.4.1] Release 12.4.1 #1449

wants to merge 3 commits into from

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Mar 7, 2025

Description

There was an issue with PocketSVG 2.8.0 that causes all ownBrander builds / clean Xcode builds to fail due to a missing PocketSVG framework, resulting in a crash on startup.

Related Issue

#1448

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

…ilds / clean Xcode builds to fail due to a missing PocketSVG framework, resulting in a crash on startup.
@hosy hosy requested review from DeepDiver1975 and jesmrec March 7, 2025 10:41
@hosy hosy self-assigned this Mar 7, 2025
@@ -0,0 +1,5 @@
Bugfix: Missing Framework

There was an issue with PocketSVG 2.8.0 that causes all ownBrander builds / clean Xcode builds to fail due to a missing PocketSVG framework, resulting in a crash on startup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that all dependencies are now pinned to an explicit version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jesmrec
Copy link
Contributor

jesmrec commented Mar 7, 2025

Release approved from my side

app commit: 722b1645
sdk commit: 1bf0da8d

Xcode: 16.2 (16C5032a)

Basic checks:

  • Fresh install
  • Smoke test
    • Auth (basic, oauth2, oidc)
    • Transfers
    • Multiaccount
    • Security (passcode / pattern)
  • Upgrade from latest stable

E2E execution vs oCIS 7.1.0: https://reports.cucumber.io/reports/c643cbdc-659f-40f6-b171-5f0e6b23fe6a

That's approved on my side.

@hosy hosy requested a review from DeepDiver1975 March 7, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants