bugfix: set correct html lang attribute #12478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/web-runtime/src/App.vue:162
- Ensure that the value passed as the 'language' property to setCurrentLanguage is correct; if a translation function is expected (such as $gettext), consider passing that instead of the entire getText object.
setCurrentLanguage({ language: getText, languageSetting: currentLanguage })
mzner
force-pushed
the
bugfix/wrong-html-lang-attribute
branch
4 times, most recently
from
f77f319 to
4b123ce
Compare
mzner
force-pushed
the
bugfix/wrong-html-lang-attribute
branch
from
4b123ce to
5ac6186
Compare
|
|
I still see the lang incorrect:
|
LukasHirt
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added a fix to ensure that the HTML lang attribute is set correctly in the web application. This change improves accessibility and ensures that screen readers and other assistive technologies can properly interpret the language of the content.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: