[3/n] [daft-derive] attempt to better annotate semantic errors #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
commented
Mar 8, 2025
Comment on lines
+93
to
+94
| - name: Test without ui_test | ||
| run: just powerset nextest run -E 'not binary(ui_test)' |
There was a problem hiding this comment.
Had to use nextest for this because cargo test doesn't provide a way to exclude a binary.
sunshowers
commented
Mar 8, 2025
| # The intent is to keep this updated as new stable versions are relased. | ||
|
|
||
| [toolchain] | ||
| channel = "1.85.0" |
There was a problem hiding this comment.
Had to check this in because the new file that got added produces slightly different output on 1.81.
sunshowers
commented
Mar 8, 2025
Comment on lines
+18
to
+22
| error[E0277]: the trait bound `NonDiffable: Diffable` is not satisfied | ||
| --> tests/fixtures/invalid/struct-field-not-diffable.rs:5:10 | ||
| | | ||
| 5 | #[derive(Diffable)] | ||
| | ^^^^^^^^ the trait `Diffable` is not implemented for `NonDiffable` |
There was a problem hiding this comment.
Wish I could squelch these errors -- sadly not possible at the moment due to rust-lang/rust#48214.
andrewjstone
approved these changes
Mar 10, 2025
| error[E0277]: the trait bound `NonDiffable: Diffable` is not satisfied | ||
| --> tests/fixtures/invalid/struct-field-not-diffable.rs:8:5 | ||
| | | ||
| 8 | b: NonDiffable, |
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
changed the base branch from
sunshowers/spr/main.3n-daft-derive-attempt-to-better-annotate-semantic-errors
to
main
sunshowers
deleted the
sunshowers/spr/3n-daft-derive-attempt-to-better-annotate-semantic-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some span info to try and annotate semantic errors better (such as
highlighting the name of the field that's not diffable).
This isn't perfect for now because we still produce some call-site errors, but
at least we produce one error that's attributed directly to the field name so
rust-analyzer should be happy. I tried adding more bounds but ran into
rust-lang/rust#48214.