Skip to content

Update dependencies and expected output #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Update dependencies and expected output #140

merged 1 commit into from
Oct 13, 2021

Conversation

smklein
Copy link
Contributor

@smklein smklein commented Oct 13, 2021

Fixes #138

This is the result of checking out main, and running:

$ cargo update
$ TRYBUILD=overwrite cargo test

I believe this implies the version of our dependencies may cause different compiler output.

@ahl
Copy link
Collaborator

ahl commented Oct 13, 2021

What dependency led to this change or was it a difference in the version of the toolchain?

@smklein
Copy link
Contributor Author

smklein commented Oct 13, 2021

What dependency led to this change or was it a difference in the version of the toolchain?

Ultimately, it was a dependency, not the toolchain as I originally expected. I didn't bisect the deps, I just did cargo update, so I'm actually unsure which one it was (... I can dig, but frankly, do we care?).

@ahl
Copy link
Collaborator

ahl commented Oct 13, 2021

(... I can dig, but frankly, do we care?).

No need for you to dig. I (though perhaps not we) care because it's surprising that a dependency could cause this change. The only one that makes sense is trybuild and indeed that seems to be what happened:

dtolnay/trybuild#132

@smklein
Copy link
Contributor Author

smklein commented Oct 13, 2021

(... I can dig, but frankly, do we care?).

No need for you to dig. I (though perhaps not we) care because it's surprising that a dependency could cause this change. The only one that makes sense is trybuild and indeed that seems to be what happened:

dtolnay/trybuild#132

Ah, good find. I didn't mean to sound dismissive - I only figured the solution would remain the same regardless of the culprit!

Thanks for the look.

@smklein smklein merged commit 4009918 into main Oct 13, 2021
@smklein smklein deleted the update-output branch October 13, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions can be broken by changed compiler output
2 participants