lib-dice: Replace START / END with Range in cert templates. #761
Conversation
| where | ||
| Self: Sized, | ||
| T: TryFrom<&'a [u8]>, |
There was a problem hiding this comment.
There's nothing inherent about TryFrom<&[u8]> that says it can only return Ok if the entire slice is used. It happens that you use a pattern of let x: [u8; X] = self.read_range(R) which means T is TryFrom<&'a [u8]> for [u8; N] which does fail if the slice and array lengths are different (I had to go look that up: https://doc.rust-lang.org/src/core/array/mod.rs.html#177-186). I'm not sure if that was an intentional choice here or whether T should always consume the entire slice provided. This feels like an easy place to make a mistake but I can't think of any easy way to detect such an error.
There was a problem hiding this comment.
This pattern was intentional. It was the best option I could come up with that didn't rely on an unstable feature (generic_const_exprs I think but my understanding of this is limited). If you're OK with enabling incomplete / unstable features this can be updated, or we can wait for the feature to stabilize. I've created an issue to track this: #778
lib/dice/src/cert.rs
Outdated
|
|
||
| self | ||
| fn write_range<T: AsBytes>(&mut self, r: Range<usize>, t: &T) { |
There was a problem hiding this comment.
| fn write_range<T: AsBytes>(&mut self, r: Range<usize>, t: &T) { | |
| fn set_range<T: AsBytes>(&mut self, r: Range<usize>, t: &T) -> Self { |
Name change to align with functions that use it. Returning self to avoid all of the set_* methods from needing to explicitly return self themselves.
There was a problem hiding this comment.
I'll do the same for 'read' vs 'get'
This simplifies the get / set functions in the Cert trait. This resolves oxidecomputer#747
…puter#761) This simplifies the get / set functions in the Cert trait. This resolves oxidecomputer#747
…puter#761) This simplifies the get / set functions in the Cert trait. This resolves oxidecomputer#747
This simplifies the get / set functions in the Cert trait. This resolves #747