Skip to content

[VM metrics] add a metric for VMM VSZ #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[VM metrics] add a metric for VMM VSZ #8071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions oximeter/oximeter/schema/virtual-machine.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ versions = [
{ added_in = 1, fields = [ "state", "vcpu_id" ] }
]

[[metrics]]
name = "vmm_vsz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhat on the fence about this naming, since the oximeter metrics are functionally a public user interface; I might consider not abbreving vsz for clarity? but i might be wrong about that...

description = "Total virtual memory reserved for reasons other than direct access by the virtual machine"
units = "bytes"
datum_type = "u64"
versions = [
{ added_in = 1, fields = [ ] }
]

[[metrics]]
name = "reset"
description = "Cumulative number of times the virtual machine has been reset"
Expand Down
Loading