Skip to content

[external API] alerts: the renamening #8169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b8fdb3a
WHEW
hawkw May 8, 2025
0f3c38b
more pain
hawkw May 8, 2025
6694d25
reticulating views
hawkw May 12, 2025
4f4f371
rename some internal files
hawkw May 14, 2025
9f6b866
split "webhook" and "alert" fns into separate files
hawkw May 14, 2025
84fd31e
rename absolutely E•V•E•R•Y•T•H•I•N•G
hawkw May 14, 2025
57168cf
more fixy
hawkw May 15, 2025
01cc404
omdb expectorate update
hawkw May 15, 2025
b1dd690
polar should use correct name
hawkw May 15, 2025
2385fda
update authz endpoint tests
hawkw May 15, 2025
b850c5f
update webhook tests
hawkw May 15, 2025
33abcdd
migration to rename DB tables
hawkw May 15, 2025
904c9e1
rename typed uuid kind i forgot about
hawkw May 15, 2025
571abf1
more internal renaming
hawkw May 15, 2025
3e62416
Merge branch 'main' into eliza/s/webhook/alert
hawkw May 15, 2025
47b19dc
post merge fixup
hawkw May 15, 2025
52c4d77
upadte expectorate query tests
hawkw May 15, 2025
63352e6
make clippy happy
hawkw May 15, 2025
953196c
docs embetterment
hawkw May 15, 2025
ac3e846
forgot to commit some of the docs embetterment
hawkw May 15, 2025
9a6ba64
OH GOD THERES MORE OF THEM
hawkw May 15, 2025
ea8feae
Update shared.rs
hawkw May 16, 2025
cd89bce
Update shared.rs
hawkw May 16, 2025
858c231
Update shared.rs
hawkw May 16, 2025
a05697c
fix accidentally renamed tests
hawkw May 16, 2025
1df6022
fix gross attribute formatting
hawkw May 16, 2025
fdadcf3
remove commented out code
hawkw May 16, 2025
e5267f8
fix name of migration
hawkw May 16, 2025
10168a0
MAKE THE MIGRATIONS ACTUALLY WORK
hawkw May 16, 2025
31b01fd
update openapi again
hawkw May 16, 2025
affced5
whoopsie
hawkw May 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/src/api/external/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,8 @@ pub enum ResourceType {
AffinityGroupMember,
AntiAffinityGroup,
AntiAffinityGroupMember,
Alert,
AlertReceiver,
AllowList,
BackgroundTask,
BgpConfig,
Expand Down Expand Up @@ -1040,8 +1042,6 @@ pub enum ResourceType {
Probe,
ProbeNetworkInterface,
LldpLinkConfig,
WebhookEvent,
WebhookReceiver,
WebhookSecret,
}

Expand Down
11 changes: 5 additions & 6 deletions dev-tools/omdb/src/bin/omdb/db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ use crate::helpers::CONNECTION_OPTIONS_HEADING;
use crate::helpers::DATABASE_OPTIONS_HEADING;
use crate::helpers::const_max_len;
use crate::helpers::display_option_blank;
use alert::AlertArgs;
use anyhow::Context;
use anyhow::anyhow;
use anyhow::bail;
Expand Down Expand Up @@ -169,11 +170,9 @@ use std::sync::Arc;
use strum::IntoEnumIterator;
use tabled::Tabled;
use uuid::Uuid;
use webhook::WebhookArgs;
use webhook::cmd_db_webhook;

mod alert;
mod saga;
mod webhook;

const NO_ACTIVE_PROPOLIS_MSG: &str = "<no active Propolis>";
const NOT_ON_SLED_MSG: &str = "<not on any sled>";
Expand Down Expand Up @@ -387,8 +386,8 @@ enum DbCommands {
Vmms(VmmListArgs),
/// Print information about the oximeter collector.
Oximeter(OximeterArgs),
/// Print information about webhooks
Webhook(WebhookArgs),
/// Print information about alerts
Alert(AlertArgs),
/// Commands for querying and interacting with pools
Zpool(ZpoolArgs),
}
Expand Down Expand Up @@ -1467,7 +1466,7 @@ impl DbArgs {
command: OximeterCommands::ListProducers
}) => cmd_db_oximeter_list_producers(&datastore, fetch_opts).await,

DbCommands::Webhook(args) => cmd_db_webhook(&opctx, &datastore, &fetch_opts, &args).await,
DbCommands::Alert(args) => alert::cmd_db_alert(&opctx, &datastore, &fetch_opts, &args).await,
DbCommands::Zpool(ZpoolArgs {
command: ZpoolCommands::List(args)
}) => cmd_db_zpool_list(&opctx, &datastore, &args).await,
Expand Down
Loading
Loading