Skip to content

Add parallel-task-set crate, test it, use it #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add parallel-task-set crate, test it, use it #8174

wants to merge 2 commits into from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented May 15, 2025

Follow-up from support bundles work.

This crate exposes a "JoinSet"-like interface which also has a bound on maximum parallelism.

@smklein smklein requested a review from papertigers May 15, 2025 22:41
@smklein smklein mentioned this pull request May 15, 2025
Open
@smklein smklein requested a review from hawkw May 15, 2025 23:27
hawkw
hawkw approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, with a couple of nits. there are some places in Nexus we could use this too!

@hawkw
Copy link
Member

hawkw commented May 16, 2025

Test failure in build-and-test (helios) looks like a flake (in one of my tests, agh).

@hawkw hawkw mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@papertigers papertigers Awaiting requested review from papertigers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @hawkw