opteadm/OpteHdl cleanup

.github/buildomat/jobs/p5p.sh

@@ -34,7 +34,7 @@ source .github/buildomat/common.sh
 #
 TGT_BASE=${TGT_BASE:=/work}
 
-REL_SRC=target/x86_64-unknown-unknown/release
+REL_SRC=target/x86_64-unknown-unknown/release-lto
 REL_TGT=$TGT_BASE/release
 
 mkdir -p $REL_TGT
@@ -43,7 +43,7 @@ cargo --version
 rustc --version
 
 header "build xde and opteadm (release+debug)"
-ptime -m cargo xtask build
+ptime -m cargo xtask build --profile all
 
 #
 # Inspect the kernel module for bad relocations in case the old
@@ -55,7 +55,7 @@ if elfdump $REL_SRC/xde | grep GOTPCREL; then
 fi
 
 header "package opte"
-cargo xtask package --skip-build
+cargo xtask package --skip-build --profile all
 
 banner copy
 pfexec mkdir -p /out

.github/buildomat/jobs/xde.sh

@@ -45,7 +45,7 @@ DBG_SRC=target/x86_64-unknown-unknown/debug
 DBG_LINK_SRC=target/i686-unknown-illumos/debug
 DBG_TGT=$TGT_BASE/debug
 
-REL_SRC=target/x86_64-unknown-unknown/release
+REL_SRC=target/x86_64-unknown-unknown/release-lto
 REL_LINK_SRC=target/i686-unknown-illumos/release
 REL_TGT=$TGT_BASE/release
 
@@ -72,13 +72,13 @@ ptime -m cargo clippy -- \
     --allow clippy::uninlined-format-args --allow clippy::bad_bit_mask
 popd
 
+popd
+
 header "build xde (debug)"
-ptime -m ./build-debug.sh
+ptime -m cargo xtask build --profile debug xde xde-link
 
 header "build xde (release)"
-ptime -m ./build.sh
-
-popd
+ptime -m cargo xtask build --profile release xde xde-link
 
 #
 # Inspect the kernel module for bad relocations in case the old

Cargo.toml

@@ -83,6 +83,7 @@ poptrie = { git = "https://github.com/oxidecomputer/poptrie", branch = "multipat
 
 [profile.release]
 debug = 2
+lto = "thin"
 
 [profile.release-lto]
 inherits = "release"

bench/src/packet.rs

@@ -25,7 +25,6 @@ use opte_test_utils::icmp::RawHardwareAddress;
 use opte_test_utils::icmp::gen_icmp_echo;
 use opte_test_utils::icmp::gen_icmpv6_echo;
 use opte_test_utils::icmp::generate_ndisc;
-use opte_test_utils::overlay::BOUNDARY_SERVICES_VNI;
 use opte_test_utils::*;
 
 pub type TestCase = (MsgBlk, Direction);

bin/opteadm/Cargo.toml

@@ -10,9 +10,9 @@ repository.workspace = true
 # XXX For the time being opteadm needs to set the engine feature to
 # get all the types. Once there types are move to their appropriate
 # place this feature flag will be replaced/removed.
-opte = { workspace = true, features = ["api", "engine", "std"] }
+opte = { workspace = true, features = ["api", "std"] }
 opte-ioctl.workspace = true
-oxide-vpc = { workspace = true, features = ["api", "engine", "std"] }
+oxide-vpc = { workspace = true, features = ["api", "std"] }
 
 anyhow.workspace = true
 cfg-if.workspace = true