ENH: Add tzdata to hard dependencies #61308
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,7 @@ Other enhancements | |||
| - :meth:`pandas.concat` will raise a ``ValueError`` when ``ignore_index=True`` and ``keys`` is not ``None`` (:issue:`59274`) | |||
| - :py:class:`frozenset` elements in pandas objects are now natively printed (:issue:`60690`) | |||
| - Add ``"delete_rows"`` option to ``if_exists`` argument in :meth:`DataFrame.to_sql` deleting all records of the table before inserting data (:issue:`37210`). | |||
| - Added ``tzdata`` to the ``_hard_dependencies`` (:issue:`61273`) | |||
There was a problem hiding this comment.
_hard dependencies is the internal name of the variable. I think tzdata is already required according to our docs, I guess we may want to have a note for a bug where tzdata being installed wasn't checked? @rhshadrach @mroeschke
There was a problem hiding this comment.
Agreed. As only user facing-changes go in the whatsnew, I'd be fine with no note here at all. tzdata was being checked and would certainly raise an import error upon import of pandas, adding it to _hard_dependencies makes the message a bit more clear. If we do go with a note, I'd suggest it stay in other enhancements but be something like
Improved error message when importing pandas and ``tzdata`` is not installed (:issue:`61273`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tzdatato the_hard_dependencies#61273doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.