BLD: Build wheels for 3.9 and musllinux-aarch64 for pandas 2.3 #61569
Conversation
|
I guess the issue is the tag would have to be named something else (at this point, I don't think it's a good idea to delete and re-tag), and that point it's probably better to make a new version. It might be easier to download wheel artifacts from this PR and upload them by hand using twine, though. |
mroeschke
changed the title
| @@ -2,7 +2,7 @@ | |||
| project( | |||
| 'pandas', | |||
| 'c', 'cpp', 'cython', | |||
| version: run_command(['generate_version.py', '--print'], check: true).stdout().strip(), | |||
| version: '2.3.0', | |||
There was a problem hiding this comment.
@lithomas1 so I'm just trying to upload the 3.9 packages with twine from this PR, and originally I'm getting
The use of local versions in <Version('2.3.0+3.g313260cf75')> is not allowedSo I'm guessing this line is adding the extra git hash in the metadata. Do you know if I'll need to hard code the version elsewhere?
There was a problem hiding this comment.
I think instead of using versioneer here (https://github.com/pandas-dev/pandas/pull/61569/files#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4R31-R45), we can hardcode the _version_meson.py file using a shell script or command or something.
It's been a while but I think the file just outputs a __version__ and __git_version__ variable.
There was a problem hiding this comment.
The wheel build when hardcoding this produced wheels with a version twine accepted so I guess this worked 🤷 https://pypi.org/project/pandas/2.3.0/#files
|
Thanks again for the guidance @lithomas1. Closing this out |
Shouldn't this be at least partially merged into |
Yup definitely. I've tracked this task in #61590 as the core team discusses the possibility of a 2.3.1 release |
@lithomas1 would I need to re-tag the 2.3.x branch if/when we merge this?
xref #61563 #61574