Skip to content

backport 222 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2018
Merged

backport 222 #225

merged 1 commit into from
Jan 15, 2018

Conversation

debris
Copy link
Contributor

@debris debris commented Jan 15, 2018

backport of #222 to parity-1.9 branch

@Marwes @debris
Fix Params deserialization on serde_json>=1.0.8 (#222)
776503b 
* Fix Params deserialization on serde_json>=1.0.8

Due to serde-rs/json#389, serde_json no longer calls `deserialize_any` in `deserialize_identifer` (and all other default implemented methods). This causes `Params` to fail to deserialize maps and sequences since it has hinted that it expects an identifier.

This implements `deserialize` correctly, saying that it accepts any type.

* Fix Id deserialization on serde_json>=1.0.8
@debris debris merged commit 162ad18 into parity-1.9 Jan 15, 2018
@debris debris deleted the backport_222 branch January 15, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debris @Marwes