Fix: [Referenda Tracks] Resolve representation issues that are breaking PJS apps #7671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2025
pandres95
force-pushed
the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
from
6fe1641 to
f7f6920
Compare
…y like a string change(pallet-referenda): create const function that helps construct `StringLike` to reduce changes in tracks definitions fix: fmt
pandres95
force-pushed
the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
from
e8538fe to
44b58c7
Compare
bkchr
reviewed
Feb 24, 2025
ggwpez
reviewed
Feb 24, 2025
ggwpez
reviewed
Feb 24, 2025
|
Are we going to merge this, or revert as per #7661? |
bkchr
reviewed
Mar 12, 2025
… version) and `ConstTrackInfo` (const version) that "extend" from `TrackDetails` (generic version).
pandres95
force-pushed
the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
from
36f5d50 to
28ad818
Compare
gui1117
approved these changes
Mar 13, 2025
ggwpez
added
the
A4-backport-stable2503
ggwpez
approved these changes
Mar 21, 2025
Merged
via the queue into
paritytech:master
with commit Mar 21, 2025
467d1f6
249 of 256 checks passed
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7671-to-stable2503
git worktree add --checkout .worktree/backport-7671-to-stable2503 backport-7671-to-stable2503
cd .worktree/backport-7671-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 467d1f642c8d5d6b11c45e5212f546af86b6f6e4
git push --force-with-lease |
pandres95
deleted the
fix/represent-tracks-constant-as-a-vec-id-info-tuple
branch
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 26, 2025
Backport #7671 into `stable2503` from pandres95. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Egor_P <[email protected]>
pandres95
added a commit
to virto-network/polkadot-sdk
that referenced
this pull request
Apr 23, 2025
…ng PJS apps (paritytech#7671) This Pull Request fixes the following issues present with PJS derived from paritytech#2072 - Represents `Tracks` constant as a `Vec<(TrackId, TrackInfo)>` instead of `Vec<Track>`, so tracks iteration in PJS apps _Governance_ hook remains as how it was before, and  - Encapsulates `[u8; N]` from `name` field in a `StringLike` structure that represents its `TypeInfo` as a `&str` and encodes as such. This fixes errors present in PJS apps that treat `name` as a javascript `string`.  --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
pandres95
added a commit
to virto-network/polkadot-sdk
that referenced
this pull request
Apr 23, 2025
…ng PJS apps (paritytech#7671) This Pull Request fixes the following issues present with PJS derived from paritytech#2072 - Represents `Tracks` constant as a `Vec<(TrackId, TrackInfo)>` instead of `Vec<Track>`, so tracks iteration in PJS apps _Governance_ hook remains as how it was before, and  - Encapsulates `[u8; N]` from `name` field in a `StringLike` structure that represents its `TypeInfo` as a `&str` and encodes as such. This fixes errors present in PJS apps that treat `name` as a javascript `string`.  --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
pandres95
added a commit
to virto-network/polkadot-sdk
that referenced
this pull request
Apr 23, 2025
…ng PJS apps (paritytech#7671) This Pull Request fixes the following issues present with PJS derived from paritytech#2072 - Represents `Tracks` constant as a `Vec<(TrackId, TrackInfo)>` instead of `Vec<Track>`, so tracks iteration in PJS apps _Governance_ hook remains as how it was before, and  - Encapsulates `[u8; N]` from `name` field in a `StringLike` structure that represents its `TypeInfo` as a `&str` and encodes as such. This fixes errors present in PJS apps that treat `name` as a javascript `string`.  --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (26 commits) Snowbridge V2 (#7402) [AHM] Revert multi-block election, slashing and staking client pallets (#7939) docs: update local ci execution instruction (#8003) Upgrade deps to eliminate ancient dependencies (#7999) Removed `pallet:getter` from XCM pallets (#7916) Add digest processor xcm emulator (#7915) Fix: [Referenda Tracks] Resolve representation issues that are breaking PJS apps (#7671) Improve XCMP weight metering (#7963) bump version of zombienet-sdk (#7964) rpc-v2/archive: Rename archive call method result to value (#7885) Bump parachains runtime api to 13 (#7981) `bp-runtime`: make macro expansion not rely on `sp-std` in scope. (#7978) [CI/CD] Refactor backports flow so that it can determine automatically where to do a backport based on labels (#7976) Treasury: update expire date on payout (#7958) (#7959) `fatxpool`: report_invalid: do not ban Future/Stale txs from re-entering the view (#7777) Fix XCM Barrier Rejection Handling to Return Incomplete with Weight (#7843) Bump openssl from 0.10.64 to 0.10.70 (#7442) runtime-api: remove redundant version checks (#7610) Upgrade link-checker cache to v4 (#7874) Updating readmes (#7950) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the following issues present with PJS derived from #2072
Tracksconstant as aVec<(TrackId, TrackInfo)>instead ofVec<Track>, so tracks iteration in PJS apps Governance hook remains as how it was before, and[u8; N]fromnamefield in aStringLikestructure that represents itsTypeInfoas a&strand encodes as such. This fixes errors present in PJS apps that treatnameas a javascriptstring.