Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Update solang and canvas-node in contracts CI image #237

Merged
merged 10 commits into from
Dec 1, 2020

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Nov 4, 2020

Can't be merged until paritytech/canvas#21 is resolved, this will break the test job in cargo-contracts CI. Other than that, fmt and build are successful.

Temporary workaround: use-ink/cargo-contract#114

  • solang update to v0.1.2, newer versions did not work
  • canvas-node binary included as an artifact from the latest master
  • clang-8 set as a linker
  • python3 set as default

Closes paritytech/ci_cd#1
Closes paritytech/ci_cd#18

@TriplEight TriplEight self-assigned this Nov 4, 2020
@TriplEight TriplEight changed the title WIP: remove solang from contracts image Temporarily remove solang and canvas-node from contracts image Nov 5, 2020
@TriplEight TriplEight changed the title Temporarily remove solang and canvas-node from contracts image Update solang and canvas-node in contracts CI image Nov 10, 2020
@TriplEight
Copy link
Contributor Author

@ascjones @cmichi @Robbepop how to proceed with it? Is there any progress with paritytech/canvas#21

@ascjones
Copy link
Contributor

I thought that paritytech/canvas#21 is solved by this PR, because the binary no longer is compiled by this image, instead it is now downloaded from the result of the canvas-node CI which currently runs successfully.

@TriplEight
Copy link
Contributor Author

@ascjones sort-ta. There's no problem to build cargo-contract within this image, I specifically tested this.
But the test job of cargo-contract CI would fail on the same error: could not compile sp-arithmetic.

@ascjones
Copy link
Contributor

Summary:

  • cargo-contract depends on the latest release of substrate 2.0.0 on crates.io
  • substrate 2.0.0 fails to build with nightly > 2020-10-01
  • This PR produces an image which contains a newer (incompatible) version of nightly

Therefore this PR should not be merged until a new version of substrate is available on crates.io which can compile with the latest nightly, and cargo-contract has been upgraded to depend on that version.

@TriplEight TriplEight merged commit 9057a55 into master Dec 1, 2020
@TriplEight TriplEight deleted the remove_solang_f_contracts branch December 1, 2020 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants