This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Document more TODOs as tickets #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
the
A3-in_progress
gnunicorn
commented
Jan 14, 2019
gnunicorn
commented
Jan 14, 2019
gnunicorn
commented
Jan 15, 2019
| @@ -21,7 +21,7 @@ | |||
| //! The pool is able to return an iterator that traverses transaction | |||
| //! graph in the correct order taking into account priorities and dependencies. | |||
| //! | |||
| //! TODO [ToDr] | |||
| //! FIXME [ToDr] | |||
| //! - [ ] Multi-threading (getting ready transactions should not block the pool) | |||
There was a problem hiding this comment.
we should remove these two lines.
core/trie/src/trie_stream.rs
Outdated
| @@ -94,7 +94,7 @@ impl trie_root::TrieStream for TrieStream { | |||
| _ => { | |||
| // println!("[append_substream] would have hashed, because data.len() = {}", data.len()); | |||
| // data.encode_to(&mut self.buffer) | |||
| // TODO: re-enable hashing before merging | |||
| // FIXME: re-enable hashing before merging | |||
There was a problem hiding this comment.
clearly old comments. let's remove
gnunicorn
added
A2-insubstantial
gnunicorn
added
A3-in_progress
gnunicorn
changed the title
gnunicorn
added
A2-insubstantial
tomusdrw
reviewed
Jan 25, 2019
| @@ -305,7 +305,6 @@ impl<B: ChainApi> Pool<B> { | |||
|
|
|||
| impl<B: ChainApi> Pool<B> { | |||
| /// Create a new transaction pool. | |||
| /// TODO [ToDr] Options | |||
There was a problem hiding this comment.
This one is actually still valid, logged here: #1579
There was a problem hiding this comment.
Thanks for logging, @tomusdrw but do you think this needs a code comment here as well? I think the ticket is more than fine enough :) .
There was a problem hiding this comment.
No, it's not needed. I'm actually tacking the issue right away anyway :)
bkchr
approved these changes
Jan 28, 2019
rphmeier
pushed a commit
that referenced
this pull request
Jan 30, 2019
Went through the TODOs, removed a bunch, which are outdated or nothing more than a regular comment, documented a bunch more as actual tickets and made them FIXMEs and unified their structure (`FIXME #TICKETNO DESC` for local tickets, `FIXME: DESC LINK` for external tickets) for easier in-editor support. Further more remove unnecessary remarks and related old code that I noticed in that instance.
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
Went through the TODOs, removed a bunch, which are outdated or nothing more than a regular comment, documented a bunch more as actual tickets and made them FIXMEs and unified their structure (`FIXME #TICKETNO DESC` for local tickets, `FIXME: DESC LINK` for external tickets) for easier in-editor support. Further more remove unnecessary remarks and related old code that I noticed in that instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through the TODOs, removed a bunch, which are outdated or nothing more than a regular comment, documented a bunch more as actual tickets and made them FIXMEs and unified their structure (
FIXME #TICKETNO DESCfor local tickets,FIXME: DESC LINKfor external tickets) for easier in-editor support. Further more remove unnecessary remarks and related old code that I noticed in that instance.