Skip to content

ci: Fix flaky sendVerificationEmail tests #9692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 2, 2025

Pull Request

Issue

sendVerificationEmail runs in the background so you need to wait until it's finished

Closes: #9274
Closes: #9275
Closes: #9276

Approach

  • Use deferred promises
  • Remove jasmine.timeout where needed
  • Refactor tests to use async / await

Copy link

parse-github-assistant bot commented Apr 2, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (e86718f) to head (57a9867).
Report is 3 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9692   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         187      187           
  Lines       15081    15081           
  Branches      174      174           
=======================================
  Hits        14028    14028           
  Misses       1041     1041           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dplewis added 2 commits April 13, 2025 23:39
Signed-off-by: Diamond Lewis <findlewis@gmail.com>
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for merge? Re-running CI to see whether still flaky...

@dplewis
Copy link
Member Author

dplewis commented Apr 14, 2025

This is ready to merge

@mtrezza mtrezza changed the title ci: Fix flaky sendVerificationEmail tests ci: Fix flaky sendVerificationEmail tests Apr 15, 2025
@mtrezza mtrezza merged commit ed69e03 into parse-community:alpha Apr 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment