Skip to content

Update type of cents_usd response fields #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Update type of cents_usd response fields #33

merged 3 commits into from
Jul 14, 2021

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Jul 14, 2021

What

  • Update order.price_cents_usd and order.patch_fee_cents_usd from string to integer

Why

  • An integer value is more natural and directly usable by a consumer of the API

Notes

  • This version can be released even before the API update since the javascript type conversion is pretty friendly. With the current API version it coerces the string nicely to integer.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from bspellacy July 14, 2021 20:38
@pcothenet pcothenet changed the title Update type of cents_usd Update type of cents_usd response fields Jul 14, 2021
@pcothenet pcothenet merged commit 36c9bb4 into main Jul 14, 2021
@pcothenet pcothenet deleted the pc/17 branch July 14, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants