Skip to content

Support for Manifest Serialization by Privileged Agent #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

warfaj
Copy link
Member

@warfaj warfaj commented Jan 8, 2024

  • Added the source file to manifest for each component (required changes to pax-macro, pax-manifest)
  • Refactored manifest serialization & formatting code to share logic. Improved handling for inline templates. (pax-compiler)
  • Added functionality to serialize a component definition to file path, supporting both .pax & .rs (pax-compiler)
  • Created e2e serialization test using test project (pax-compiler/tests)
  • Fixed new project template to include pax-manifest crate since it's now a dependency. (pax-compiler)

In creating the e2e test, I stumbled upon this bug in cargo. TLDR: cargo doesn't support excluding paths from a workspace that are within a member. This was causing an annoying breakage when i tried to run the test project within pax-compiler. I got around it by making the test project a workspace itself. Noting it here for posterity.

warfaj added 5 commits January 4, 2024 16:16
…ng for inline templates. Supported functionality required by privileged agent to serialize to a file path. Created an e2e serialization test. Fixed new project template to include pax-manifest crate since it was breaking
@warfaj warfaj requested a review from zackbrown January 8, 2024 00:36
Copy link
Member

@zackbrown zackbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zackbrown zackbrown merged commit 73dc4ac into dev Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants