fix(ui): prefer adminThumbnail even if file is non-image #11948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhrarovsaid
changed the title
PatrikKozak
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR relaxes the mimeType checks in the thumbnail and file cell components to accommodate an
adminThumbnaileven if the file is a non-image. This is useful when, for example, using anadminThumbnailfunction to retrieve or generate thumbnails for files that are non-images such as videos.Why?
To prioritize an admin thumbnail if/when available on file cells and upload field thumbnails in both edit and list views.
How?
By relaxing the mimeType checks in the
Thumbnailcomponent and instead lifting that responsibility on the caller of this component. Some of these checks were not needed as the best-fit helper utility function will automatically select the thumbnailURL if available or revert to the original url if no best-fit is found.Demo of admin thumbnail being loaded on non-image while still selecting best-fit size for images:
