feat(ui): use defaultDepth in API view #11950
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tak-amboss I am good with this! I believe defaultDepth is set even when undefined in the config. Can you confirm? And then we can merge this in. |
|
Thanks @JarrodMFlesch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Respects the defaultDepth setting in the admin UI API view.
Why?
The current default is hardcoded to
1with no configuration option. This can lead to performance issues on documents with a lot of related large documents. Having the ability to define a different default can prevent this issue.How?
Set the depth in the API view to
config.defaultDepthas default.