fw: black notification banner with inverted icon on black and white watches #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplexer
force-pushed
the
jplexer/silk_notif
branch
from
fba1108 to
0e48841
Compare
|
I saw your comment and put it on my list for Tuesday. |
|
We really need to make clang-format stop making so much noise. I like this, though. |
HBehrens
reviewed
Apr 22, 2025
src/fw/applib/ui/kino/kino_layer.c
Outdated
| .command = prv_invert_pdc_colors, | ||
| }; | ||
|
|
||
| KinoReelProcessor invert_processor = {.draw_command_processor = &gdraw_inv_processor}; |
There was a problem hiding this comment.
This will similarly require values for bitmap_processor. Of course, this could happen at a follow-up PR. My recommendation would be to not solve with via GBitmapProcessor.pre or .post but a new field composite_mode for a lot of orthogonal power.
jplexer
force-pushed
the
jplexer/silk_notif
branch
from
0e48841 to
c150bd4
Compare
|
did most of the things you pointed out @HBehrens, will look into tests and inversion logic for full color soon! |
Signed-off-by: Joshua Jun <[email protected]>
jplexer
force-pushed
the
jplexer/silk_notif
branch
from
c150bd4 to
7632efc
Compare
|
rebased to remove all the clang-format changes and make more obvious what my changes are :) |
Signed-off-by: Joshua Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to make notification banners on bw watches a bit nicer
(design wise signed off by @lavglaab )