-
Notifications
You must be signed in to change notification settings - Fork 46
platform: re-enable HAS_BUILTIN_HRM capability #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
37e59da
to
559a0e7
Compare
c658574
to
6a1a40a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's avoid pulling binary blobs in tree, reasons:
- Licensing (unclear?)
- Binaries blow up git history
I'd suggest creating a sort of https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/ and add it as a submodule.
Do we want to do the same for the pre-preprocessed fonts that were added, for the same reasons? If so, the firmware name makes less sense. Would a repo named something like |
We probably should, yes. |
We now have https://github.com/pebble-dev/pebble-nonfree to put these. Let's add the blob there first and then pull it in via this PR. I think we'll have to push an initial commit before you can PR that repo (I can do it but not till this evening since I'm on mobile at the moment). |
removed the blob from my commit, can now be added through a submodule |
I added an initial commit to https://github.com/pebble-dev/pebble-nonfree so you can make a PR there to add the blob. Probably best setting up a folder structure like |
c572667
to
9cf9cd0
Compare
Signed-off-by: Joshua Jun <[email protected]>
Signed-off-by: Joshua Jun <[email protected]>
Signed-off-by: Joshua Jun <[email protected]>
added flag --enable_silk_hr that can be run at ./waf configure |
This commits re-adds the Heart Rate support for Pebble 2.
Please note that I couldn't test this completely as I borked my hrm by accidentally having the wrong blob (this commit has the right blob though!). @Hexxeh has tested this on his silk bigboard, but it would be cool if someone else could also test this :)
will close #7
requires pebble-dev/pebble-nonfree#1