Skip to content

platform: re-enable HAS_BUILTIN_HRM capability #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jplexer
Copy link

@jplexer jplexer commented Mar 5, 2025

This commits re-adds the Heart Rate support for Pebble 2.

Please note that I couldn't test this completely as I borked my hrm by accidentally having the wrong blob (this commit has the right blob though!). @Hexxeh has tested this on his silk bigboard, but it would be cool if someone else could also test this :)

will close #7
requires pebble-dev/pebble-nonfree#1

@jplexer jplexer force-pushed the pebble2-hr branch 3 times, most recently from 37e59da to 559a0e7 Compare March 5, 2025 20:18
@jplexer jplexer closed this Mar 5, 2025
@jplexer jplexer reopened this Mar 5, 2025
@jplexer jplexer closed this Mar 5, 2025
@jplexer jplexer reopened this Mar 5, 2025
@jplexer jplexer force-pushed the pebble2-hr branch 2 times, most recently from c658574 to 6a1a40a Compare March 5, 2025 20:42
@Hexxeh Hexxeh self-requested a review March 5, 2025 21:00
Copy link
Collaborator

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's avoid pulling binary blobs in tree, reasons:

  • Licensing (unclear?)
  • Binaries blow up git history

I'd suggest creating a sort of https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/ and add it as a submodule.

@Hexxeh
Copy link
Collaborator

Hexxeh commented Mar 6, 2025

let's avoid pulling binary blobs in tree, reasons:

  • Licensing (unclear?)
  • Binaries blow up git history

I'd suggest creating a sort of https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/ and add it as a submodule.

Do we want to do the same for the pre-preprocessed fonts that were added, for the same reasons? If so, the firmware name makes less sense. Would a repo named something like pebble-nonfree make sense to contain these things?

@gmarull
Copy link
Collaborator

gmarull commented Mar 6, 2025

let's avoid pulling binary blobs in tree, reasons:

  • Licensing (unclear?)
  • Binaries blow up git history

I'd suggest creating a sort of https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/ and add it as a submodule.

Do we want to do the same for the pre-preprocessed fonts that were added, for the same reasons? If so, the firmware name makes less sense. Would a repo named something like pebble-nonfree make sense to contain these things?

We probably should, yes.

@Hexxeh
Copy link
Collaborator

Hexxeh commented Mar 6, 2025

We now have https://github.com/pebble-dev/pebble-nonfree to put these. Let's add the blob there first and then pull it in via this PR. I think we'll have to push an initial commit before you can PR that repo (I can do it but not till this evening since I'm on mobile at the moment).

@jplexer
Copy link
Author

jplexer commented Mar 7, 2025

removed the blob from my commit, can now be added through a submodule

@jplexer jplexer changed the title platform: re-enable HAS_BUILTIN_HRM capability and add AS7000 firmware blob platform: re-enable HAS_BUILTIN_HRM capability Mar 7, 2025
@Hexxeh
Copy link
Collaborator

Hexxeh commented Mar 18, 2025

I added an initial commit to https://github.com/pebble-dev/pebble-nonfree so you can make a PR there to add the blob. Probably best setting up a folder structure like drivers/hrm/as7000 and putting it under there, and then you can submodule it here.

@jplexer jplexer force-pushed the pebble2-hr branch 3 times, most recently from c572667 to 9cf9cd0 Compare April 11, 2025 11:42
@jplexer
Copy link
Author

jplexer commented Apr 11, 2025

added flag --enable_silk_hr that can be run at ./waf configure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AS7000 HRM driver for Silk
3 participants