PMM-13576 valkey support #4052
Draft
PMM-13576 valkey support #4052
+10,369
−4,822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PMM-13838 Add Valkey to PMM data model * PMM-13838 Remove rendundant params * PMM-13838 Add Valkey to agent and service servers * PMM-13838 Follow up on reported linter errors * PMM-13838 Follow up on reported linter errors * Update api/inventory/v1/agents.proto Co-authored-by: Michael Okoko <[email protected]> * PMM-13838 Follow up on PR review * PMM-13838 Revert to errors.New * PMM-13838 Update the linter rules * implement api methods to add valkey service * filter service type * add valkey service * reformat and set up inventory agents API * set up change agent params endpoint * add copyright header * update license copyright year * include expose exporter option * surpress lint errors * set up connection checker for valkey * set up service info broker for valkey * fix tests * add TLS support for valkey connection checks * fix linter errors * fix skip verify parameter * ignore gosec lint * align params to satisfy linter * add api tests * drop unused parameter * add option to use redis scheme in URL * fix tests * document data model * fix typos * use tls param for tls check * fix linters and tests * drop unused field * trigger rebuild * fix api tests * drop unnecessary toLower func --------- Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #4052 +/- ##
==========================================
- Coverage 44.15% 44.00% -0.16%
==========================================
Files 369 375 +6
Lines 45306 45957 +651
==========================================
+ Hits 20007 20224 +217
- Misses 23612 24030 +418
- Partials 1687 1703 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* PMM-13838 Add Valkey to PMM data model * PMM-13838 Remove rendundant params * PMM-13838 Add Valkey to agent and service servers * PMM-13838 Follow up on reported linter errors * PMM-13838 Follow up on reported linter errors * Update api/inventory/v1/agents.proto Co-authored-by: Michael Okoko <[email protected]> * PMM-13838 Follow up on PR review * PMM-13838 Revert to errors.New * PMM-13838 Update the linter rules * implement api methods to add valkey service * filter service type * add valkey service * reformat and set up inventory agents API * set up change agent params endpoint * add copyright header * update license copyright year * include expose exporter option * surpress lint errors * set up connection checker for valkey * set up service info broker for valkey * fix tests * add TLS support for valkey connection checks * fix linter errors * fix skip verify parameter * ignore gosec lint * align params to satisfy linter * Initial pmm-agent execution support for valkey This includes triggering the binary update from supervisord and passing the relevant args/flags to the valkey_exporter. One more big part left is passing in the correct flags to support TLS, and checking the exporter docs for other flags that we might need to use. * fix valkey status * fix self-signed certs usage * fix linter errors * add api tests * drop unused parameter * add option to use redis scheme in URL * fix tests * document data model * fix typos * drop unused redis scheme --------- Co-authored-by: Alex Demidoff <[email protected]>
1 task
ademidoff
force-pushed
the
PMM-13576-valkey-support
branch
from
87b4ae5 to
6188368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13576
Link to the Feature Build: SUBMODULES-3945
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: