PMM-14021 change access level swagger #4059
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the access level for the "/swagger" endpoint from "none" to "viewer". This ensures proper visibility while maintaining security by restricting advanced permissions.
Updated the TestSwagger function in auth_test.go to replace the custom doRequest function with http.DefaultClient.Do for better error handling. Adjusted assertions to check for a 401 status code instead of 200, ensuring the tests accurately reflect the expected authentication behavior.
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #4059 +/- ##
=======================================
Coverage 43.60% 43.60%
=======================================
Files 369 369
Lines 45225 45225
=======================================
+ Hits 19719 19721 +2
+ Misses 23798 23797 -1
+ Partials 1708 1707 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
idoqo
approved these changes
May 28, 2025
ademidoff
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14021
Link to the Feature Build: SUBMODULES-3942
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: