added --cached option to scan for cached git files, useful in pre-com… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pesterhazy
requested changes
Apr 25, 2018
| (defn find-files-git-cached | ||
| [] | ||
| (let [{:keys [exit out err]} (clojure.java.shell/sh "git" "diff" | ||
| "--cached" "--name-only")] |
There was a problem hiding this comment.
could you use the -z option here, as with ls-files?
| "--cached" "--name-only")] | ||
| (when (not= exit 0) (throw (ex-info "git diff --cached failed" {:err err}))) | ||
| (->> (clojure.string/split out #"\n") | ||
| (filter #(re-matches #".*\.(clj|cljs|cljc|cljx|cljs\.hl|boot)$" %)) |
There was a problem hiding this comment.
why not use git diff --cached --name-only "*.clj" "*.cljs" ...? This would make this very similar to find-files-git
There was a problem hiding this comment.
also the duplication concerns me, you need to add new file extensions in two places
| o options OPTS edn "zprint options"] | ||
| (let [mode (or mode :print) | ||
| files (cond-> files | ||
| source (clojure.set/union (find-files-source)) | ||
| git (clojure.set/union (find-files-git)))] | ||
| git (clojure.set/union (find-files-git)) | ||
| cached (clojure.set/union (find-files-git-cached)))] |
There was a problem hiding this comment.
I think git diff would be useful as well as git diff --cached. Perhaps two options?
-D --git-diff Automatically scan for changed files using git diff
-C -git-diff-cached Automatically scan for changed files using git diff --cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mit hooks