TWCC stats: fix overflow for lost network connection #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When network connection is lost for a long period of time such that sender is not recieiving any feedback for longer than internal queue last_pkt_fb could be set to NULL in one of consequential packet removes, which should not lead to an issue.
MishaBaranov
force-pushed
the
misha/twcc_fix_overflow
branch
from
e099406 to
6bbc792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When network connection is lost for a long period of time such that sender is not receiving any feedback for longer than internal queue
last_pkt_fbcould be set to NULL in one of consequential packet removes, which should not lead to a problem.